Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Parsing client IPv6 address when a proxy is involved #457

Merged
merged 2 commits into from
Nov 22, 2022
Merged

FIX: Parsing client IPv6 address when a proxy is involved #457

merged 2 commits into from
Nov 22, 2022

Conversation

aqeelat
Copy link
Member

@aqeelat aqeelat commented Nov 20, 2022

Fixes #456

@aqeelat aqeelat force-pushed the fix_ipv6_compatibility branch from f350138 to 3f3722c Compare November 20, 2022 09:51
@codecov
Copy link

codecov bot commented Nov 20, 2022 •
edited
Loading

Codecov Report

Merging #457 (6260a7e) into master (e23b091) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   92.71%   92.74%   +0.03%     
==========================================
  Files          26       26              
  Lines         782      786       +4     
==========================================
+ Hits          725      729       +4     
  Misses         57       57
Impacted Files Coverage Δ
auditlog/middleware.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hramezani
hramezani reviewed Nov 21, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
# Changes

## Master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleaes remove this line

Copy link
Contributor

@aleh-rymasheuski aleh-rymasheuski Nov 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramezani Can we reword this to "next release"? I think it's valuable to mark the topmost block of changes in the changelog as "unreleased yet, but will be soon".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would replace it with unreleased or next release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it with Next Release

@hramezani
Copy link
Member

Thanks @aqeelat for this patch 👍
I left a small comment. Please address it. Then we are good to go

@aqeelat aqeelat force-pushed the fix_ipv6_compatibility branch from 3f3722c to 6260a7e Compare November 21, 2022 16:39
@aqeelat
Copy link
Member Author

aqeelat commented Nov 21, 2022

@hramezani Updated. Do you have an ETA on when it might be released?

@hramezani hramezani merged commit 4cdc756 into jazzband:master Nov 22, 2022
@hramezani
Copy link
Member

Thanks @aqeelat for the update.

Do you have an ETA on when it might be released?

Probably end of this week I will release a patch release.

@aqeelat aqeelat deleted the fix_ipv6_compatibility branch November 22, 2022 09:14
@ericswpark ericswpark mentioned this pull request Nov 26, 2022
Closed
vhtkrk pushed a commit to vhtkrk/django-auditlog that referenced this pull request Jan 30, 2023
FIX: Parsing client IPv6 address when a proxy is involved jazzband#457
971d63d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleh-rymasheuski aleh-rymasheuski aleh-rymasheuski left review comments

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: IPv6 REMOTE_ADDR
3 participants
@aqeelat @hramezani @aleh-rymasheuski