-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable logging on raw save and via context manager #446
Conversation
Btw I haven't added anything in the docs yet. If you want to merge I'll fix that of course. |
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 92.30% 92.43% +0.12%
==========================================
Files 24 24
Lines 728 753 +25
==========================================
+ Hits 672 696 +24
- Misses 56 57 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @robinharms for this change. In general it LGTM 👍
|
for more information, see https://pre-commit.ci
All done! Note that I assumed the next release was 2.2.0 so I used that in the docs. Sorry about the initial bad code ;) |
Thanks for the update. I left a small suggestion. |
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
Ah, missed the :: marker. Sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @robinharms for your effort! |
Related to this issue: #443
Since m2ms don't have the kwarg raw, I've added a context manager that can be used in situations when things shouldn't be logged.
My use-case is essentially large imports on a live server.