Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added verbose field name in admin #428

Merged
merged 9 commits into from
Sep 20, 2022
Merged

Added verbose field name in admin #428

merged 9 commits into from
Sep 20, 2022

Conversation

rptmat57
Copy link
Contributor

Added verbose field name also using mapping name if defined (previously the mapping would not be used)

@rptmat57
Copy link
Contributor Author

implementation of #426

@hramezani
Copy link
Member

@rptmat57 do you want to fix the failing tests?

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #428 (3d277d4) into master (acada9e) will increase coverage by 0.04%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   92.24%   92.28%   +0.04%     
==========================================
  Files          24       24              
  Lines         709      726      +17     
==========================================
+ Hits          654      670      +16     
- Misses         55       56       +1     
Impacted Files Coverage Δ
auditlog/mixins.py 86.95% <94.44%> (+1.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

auditlog/models.py Outdated Show resolved Hide resolved
auditlog/mixins.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

@rptmat57 You need to add a changelog entry in https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md

auditlog/models.py Outdated Show resolved Hide resolved
- added test when a model is unregistered to ensure admin log entries still display correctly
- added entry in CHANGELOG.md
auditlog_tests/tests.py Outdated Show resolved Hide resolved
Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@hramezani hramezani merged commit d74c118 into jazzband:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants