Moving middleware user auth check to set_actor()
#279
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check for whether the user is authenticated from before
registering
set_actor()
as thepre_save
signal receiverin to
set_actor()
. This enables two things:remote_addr
in theLogEntry
is set even if the user isnot authenticated.
on the request. Some frameworks may set this in a
following middleware. Some frameworks, such as the widely
adopeted Django Rest Framework do not set this as part
of a middleware. So, the upshot of hit is that the
actor will not be set when using Django Rest Framework.