Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build universal wheels. #46

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

ppentchev
Copy link
Contributor

Hi,

Thanks for your work on contextlib2 and Python in general!

Now that contextlib2 has only supported Python 3.x for a while, what do you think about this change that stops it from building universal wheels? It ought to be harmless, since there is a python_require specification, but still it might confuse some tools that see both "python_version": "py2.py3" and "requires_python": ">=3.6" in the PyPI metadata :)

Thanks for your time, and keep up the great work!

G'luck,
Peter

Only Python 3.x is supported, so universal wheels will only confuse
tools that examine the PyPI metadata about supported Python versions.
@graingert
Copy link
Member

but still it might confuse some tools that see both "python_version": "py2.py3" and "requires_python": ">=3.6" in the PyPI metadata :)

do you know which tools? It seems there's some confusion about what this flag should be set to: certifi/python-certifi#153 (comment)

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #46 (5373afc) into master (2dc4c04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files           1        1           
  Lines         365      365           
  Branches       29       29           
=======================================
  Hits          348      348           
  Misses         14       14           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc4c04...5373afc. Read the comment docs.

@webknjaz webknjaz merged commit 89c5189 into jazzband:master Jul 26, 2021
@ppentchev ppentchev deleted the roam-universal-wheels branch July 27, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants