Implements rename command

[larsborn]

reopened because of #58 the pr #63 was closed.

The following items will be done:

• fix PEP8 issues

• Short style flag -p would be relevant in line "@click.option('--project', default=None, nargs=2)"

• Idem with -T for cross commands consistency in line "@click.option('--tag', default=None, nargs=2)"

• same in file watson.completion

• use _replace function: That way if we change the format of the frame we will not have to edit this function.

• change

  if frame.project == old_project:
      frame._replace(project=new_project)
  

• incorp. code review by @SpotlightKid

• change CLI from --tags to subsubcommand

• rebase and squash

did I forget something?

[larsborn]

reading the newly added CONTRIBUTION.md: also todo is

• add a test for the rename command (or is it unnecessary?)
• update docu

[k4nar]

Great 👍 !

@larsborn : The commands are not tested yet (a shame ;) ), so no you don't have to write a test.

[jmaupetit]

Hi @larsborn and thank you for this! Do not hesitate to remove the WIP label once this PR is ready to merge.

[larsborn]

finally ready! :-) should I squash my commits?

It took me some time to get back to this, so new feedback is very much appreciated! If everything is alright, this is ready to merge from my side.

[SpotlightKid]

Can you update this to handle paces in project names properly, like in #122, please.

[SpotlightKid]

@larsborn Yes, when your're ready, please rebase on current master and squash.

But I wonder whether it would be better to split this into two commands, "renameproject" and "renametag"? Would make the command line a lot easier, IMHO. Required options are always a bit of an oxymoron.

[larsborn]

@SpotlightKid I suggested this interface in #62 and maybe, it wasn't discussed enough. @ALL Any additional opinions? Two commands would make the list of commands longer. Also: are there any plans to rename other things too?

Generally, my feeling is, that two commands are a slightly better idea.

[SpotlightKid]

Or what about watson rename tag <oldtag> <newtag> and watson rename project <oldproject> <newproject>? I.e. the comamnd always takes three positional params: type, old, new.

[jmaupetit]

A subsubcommand would be perfect!

[larsborn]

all right, give me a few days again :)

[larsborn]

@k4nar @SpotlightKid @jmaupetit ok. Let's try again: ready to merge from my side.

[jmaupetit]

These options are deprecated. Did you update the doc via make docs (see: https://tailordev.github.io/Watson/contributing/hack/)?

[larsborn]

forgot to update the docs. Should be ok now.

btw: how are you managing releases (or in other words: when will it be possible for me to use this feature on my "production" machine aka "without switching to the dev-master version"?)

[jmaupetit]

@SpotlightKid is working on a major release (2.0.0), but, in the meantime (if he agrees) we can release a 1.4.0 with recent changes.

Anyway, this PR should be merged to master.

[larsborn]

thx for the info. Is there anything to do on my side?

[SpotlightKid]

rename needs to be added to the list of commands in line 9 of this file as well.

[larsborn]

done.

[SpotlightKid]

Sorry that it took so long to review this. I discovered an issue with the Bash completion, which I wanted to investigate, but didn't find the time. Turned out that it is unrelated to your PR, so I'm merging it now and will push a fix for the completion file later.