Make the sync command works with the new Crick API #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 Edit: the plugin system that has been discussed in the past is still possible, yet not sure if we will invest time into it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As introduced in our recent blog post, we built a new back-end for Watson, called Crick. For now, there is no public release of the source code, but it will be open sourced soon. In the meantime, we published the specifications of its API at: http://docs.crickapi.apiary.io.
Given this new back-end API, we had to make the
synccommand work again. There won't be any side effect as AFAIK no one used it in the real world (even us), since it was not completely wired anyway.Proposal
This PR fixes Watson's
pullandpushmethods to properly consume the new API.