Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resinator includes after recent Zig build api changes #9

Merged
merged 3 commits into from
May 6, 2024

Conversation

jayrod246
Copy link
Owner

Blocked by: ziglang/zig#19605

Preprocessing for "src/studio/utest.rc" expects "core/socdef.h", which is installed by our open3dmm-core dependency/artifact. At the moment, resinator does not inherit the "directory that holds all of the installed headers" in it's search path. If that changes, some of these includes I was manually passing may become unnecessary:

open3DMM/build.zig

Lines 34 to 42 in e719be5

.flags = &.{
"/y",
"/i",
b.pathFromRoot("inc"),
"/i",
b.getInstallPath(.header, ""),
"/i",
b.pathFromRoot("src"),
},

jayrod246 added a commit that referenced this pull request Apr 17, 2024
@jayrod246 jayrod246 closed this May 6, 2024
@jayrod246 jayrod246 force-pushed the fix-resinator-includes branch from 8588dfb to 4919e11 Compare May 6, 2024 10:10
This reverts commit 8947e9d.
@jayrod246 jayrod246 reopened this May 6, 2024
@jayrod246 jayrod246 changed the title Upgrade with latest zig build api changes Fix Resinator includes after recent Zig build api changes May 6, 2024
@jayrod246 jayrod246 marked this pull request as ready for review May 6, 2024 10:27
@jayrod246 jayrod246 merged commit 6f31053 into main May 6, 2024
@jayrod246 jayrod246 deleted the fix-resinator-includes branch May 6, 2024 10:28
jayrod246 added a commit that referenced this pull request May 6, 2024
This reverts commit 8947e9d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant