Windows support: block #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added partial windows support to block
KingRial
pushed a commit
to KingRial/ghw
that referenced
this pull request
Feb 7, 2020
When collecting HW informations about disks it's also very usefull to understand how much free space is available on each partition. Here a quick example based on my "Windows support: block" jaypipes#156
jaypipes
approved these changes
Feb 7, 2020
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I have an idea on how we can remove the above Go code by just using a JOIN in the WQL statement... but we can work on that together in a followup patch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added partial windows support to block
Issue #8