Merge pull request #89 from jaydenseric/refactor-tests

Test files to upload are created in context, rather than using arbitrary project files.
jaydenseric · Jul 20, 2018 · 07cfac2 · 07cfac2
2 parents 2a507ee + a96b188
commit 07cfac2
Show file tree

Hide file tree

Showing 4 changed files with 389 additions and 387 deletions.
diff --git a/Belvedere_Apollo_Pio-Clementino_Inv1015.jpg b/Belvedere_Apollo_Pio-Clementino_Inv1015.jpg
diff --git a/changelog.md b/changelog.md
@@ -27,6 +27,7 @@
   - Test middleware error response status codes.
   - Test behavior of aborted HTTP requests.
   - Test that the app can respond if an upload is not handled.
+  - Test files to upload are created in context, rather than using arbitrary project files, via [#89](https://github.com/jaydenseric/apollo-upload-server/pull/89).
 - Improved `package.json` scripts:
   - Leveraged `npm-run-all` more for parallelism and reduced noise.
   - Removed the clean script `rimraf` dev dependency in favour of native `rm -rf`. Leaner and faster; we only support \*nix now for contributing anyway.

diff --git a/src/middleware.mjs b/src/middleware.mjs
@@ -172,7 +172,10 @@ export const processRequest = (
         })
       }
       // Discard the unexpected file.
-      else stream.resume()
+      else {
+        stream.on('error', () => {})
+        stream.resume()
+      }
     })
 
     parser.once('filesLimit', () => {