Add binaries-location option #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonaprieto please readd the |
|
Ok, I didn't know. |
|
Looks like there's still a big delta here between the original branch and your changes. Would be great to reduce that so i can adequately review it |
|
Ok, let me know if I need to do something else. After considering this PR, you need to generate the node_modules folder with the new updates again. |
|
Thank you! can you add a smoke test to https://github.com/jaxxstorm/action-install-gh-release/blob/master/.github/workflows/test.yml? |
jonaprieto
added a commit
to anoma/juvix
that referenced
this pull request
Mar 21, 2023
This PR does CI maintenance consisting of the following: - Use https://github.com/freckle/stack-action to build and test the Haskell codebase - Update Gh-release action: jaxxstorm/action-install-gh-release#39 is merged into the main branch, so we return to the original GitHub action. - Simplifies pre-commit action. Use the `SKIP` environmental variable to avoid running ormolu in the CI. - The ormolu Github action now supports version input since v11. Fixed to use `Ormolu v0.5.2`. - haskell-actions/run-ormolu#26),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter to specify a relative path to the release archive where one can find the binaries. For example, if the binaries are located in the 'bin' directory of the release archive, the parameter should be
bin. As multiple files may exist in the release archive, the optionrename-tohas no effect combined withbinaries-location.