Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPython free-threading support and basic CI env #168

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Aug 21, 2024

Description:

  • Added CPython free-threading support in the extension
  • Added GHA job to run tests with python 3.13 free-threading mode
  • Added tests inside a multi-threading context

Context:

cc @hawkinsp

@vfdev-5 vfdev-5 force-pushed the enable-free-threading-mode branch 2 times, most recently from 99f7c7b to 909fec1 Compare August 21, 2024 13:03
.github/workflows/test.yml Show resolved Hide resolved
ml_dtypes/tests/mttest_mixin.py Outdated Show resolved Hide resolved
@hawkinsp
Copy link
Collaborator

Note linter failure.

@vfdev-5 vfdev-5 force-pushed the enable-free-threading-mode branch 2 times, most recently from 266a823 to 6ae9789 Compare August 21, 2024 15:44
@hawkinsp
Copy link
Collaborator

I think you need to skip the 313t build on Windows. NumPy doesn't seem to have shipped a wheel for that.

pyproject.toml Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 force-pushed the enable-free-threading-mode branch 3 times, most recently from 04014cd to d234393 Compare August 22, 2024 15:14
@jakevdp
Copy link
Collaborator

jakevdp commented Aug 26, 2024

MacOS CI failures should be fixed by #174

.github/workflows/test.yml Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 requested a review from jakevdp August 28, 2024 20:06
@vfdev-5 vfdev-5 force-pushed the enable-free-threading-mode branch 3 times, most recently from 2fd40a5 to ec41770 Compare August 30, 2024 12:15
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I like the approach of adding new multi-threaded test cases rather than overwriting the single-threaded version.

@copybara-service copybara-service bot merged commit 6f02f77 into jax-ml:main Sep 9, 2024
18 checks passed
@vfdev-5 vfdev-5 deleted the enable-free-threading-mode branch September 9, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants