Update readthedocs.yaml to new build specification #8383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once jupyter-core 4.9.1 is released I'll repurpose this PR to remove the pinning. |
|
Second commit is testing this solution: jupyter/jupyter_core#246 (comment) |
jakevdp
force-pushed
the
test-jupyter-core
branch
from
4ef58b1
to
cfe0156
Compare
|
Last commit updates to Python 3.9 & uses RTD config from https://blog.readthedocs.com/new-build-specification/ |
jakevdp
changed the title
yashk2810
approved these changes
Oct 28, 2021
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was prompted by the discussion in jupyter/jupyter_core#246
Although jupyter-core is pushing a fix, a more long-term fix was suggested: to follow https://blog.readthedocs.com/new-build-specification/ and update the way we specify our RTD build environment. I also updated our readthedocs environment to Python 3.9, and removed the now-unnecessary pinning of jupyter-core.