Support Python 3.13 #512
Support Python 3.13 #512
Conversation
edgarrmondragon
force-pushed
the
cp313
branch
3 times, most recently
from
05dcd80
to
a5d579f
Compare
|
All checks are 🟢 over on my fork: https://github.com/edgarrmondragon/charset_normalizer/actions/runs/10896233690. That means we may just have to wait for mypy 1.12 to be released :) |
| - python-version: "3.7" | ||
| os: macos-13 |
There was a problem hiding this comment.
Python 3.7 isn't available for macos-latest (currently macos-14), so I extracted these.
There was a problem hiding this comment.
IMHO - you can remove python3.7 testing completely given that this is not supported anymore. Additionally, the README contains instructions on this lib versions that are still working with dead python versions.
edgarrmondragon
force-pushed
the
cp313
branch
from
a5d579f
to
32541ba
Compare
| @@ -45,7 +45,14 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11", "3.12" ] | |||
| python-version: | |||
| - "3.7" | |||
There was a problem hiding this comment.
IMHO you can remove 3.7 that is not supported anymore (it's been a year).
Once you add python 3.13, you could also drop python3.8 (that is official reaching EOL this October, like, in 7 days)
There was a problem hiding this comment.
Thanks for the suggestion. I think that's up to the maintainer. If the burden of keeping it around is not too big, they might wanna wait a while before dropping it.
| @@ -176,8 +183,21 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11", "3.12" ] | |||
| python-version: | |||
| - "3.8" | |||
There was a problem hiding this comment.
Ditto python 3.8 (end of support starts in 7 days)
edgarrmondragon
force-pushed
the
cp313
branch
from
32541ba
to
d5875fa
Compare
Related: