Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search not 100% accurate? #126

Closed
shotrox opened this issue May 26, 2013 · 5 comments
Closed

Search not 100% accurate? #126

shotrox opened this issue May 26, 2013 · 5 comments

Comments

@shotrox
Copy link

shotrox commented May 26, 2013

Hi
I love this plugin, it is just what I was looking for. Can you explain why it finds stuff that is not there though?

On http://www.actrox.com/search-actors/ when you start typing in the search input it works well when you for example type 'b' - it only finds Brad Pitt - but when you type 'g' it "finds" everyone... How come? What areas are searched?

Thanks

Alexander

@javve
Copy link
Owner

javve commented May 26, 2013

Hi!

Awesome that you like List.js!

I'm currently at vacation without a computer so I'll take a look at your problem when I'm back home next week!

On Sun, May 26, 2013 at 9:09 AM, shotrox notifications@github.com wrote:

Hi
I love this plugin, it is just what I was looking for. Can you explain why it finds stuff that is not there though?
On http://www.actrox.com/search-actors/ when you start typing in the search input it works well when you for example type 'b' - it only finds Brad Pitt - but when you type 'g' it "finds" everyone... How come? What areas are searched?
Thanks

Alexander

Reply to this email directly or view it on GitHub:
#126

@shotrox
Copy link
Author

shotrox commented May 26, 2013

So cool how fast you reacted! Thank you and enjoy your vacation ­ no rush.

Yeah ­ I am totally in love with it. A beauty of code! So smooth and light
weightŠ I wonder how it will manage thousands of actors once we have a lot
of themŠ

I just married it with tooltipster.js ­ another cool piece of code. Let me
know what you think so far (design is still drafty and nothing works on the
site apart of the search)

From: Jonny Strömberg notifications@github.com
Reply-To: javve/list
<reply+i-14767304-61e66358693f9d6e3ab31a9c11c5f860ebb2bfc8-1617611@reply.git
hub.com>
Date: Sunday, May 26, 2013 1:17 AM
To: javve/list list@noreply.github.com
Cc: Microsoft Office User info@schottky.com
Subject: Re: [list] Search not 100% accurate? (#126)

Hi!

Awesome that you like List.js!

I'm currently at vacation without a computer so I'll take a look at your
problem when I'm back home next week!

On Sun, May 26, 2013 at 9:09 AM, shotrox notifications@github.com wrote:

Hi
I love this plugin, it is just what I was looking for. Can you explain why it
finds stuff that is not there though?
On http://www.actrox.com/search-actors/ when you start typing in the search
input it works well when you for example type 'b' - it only finds Brad Pitt -
but when you type 'g' it "finds" everyone... How come? What areas are searched?
Thanks

Alexander

Reply to this email directly or view it on GitHub:
#126


Reply to this email directly or view it on GitHub
#126 (comment) .

@pavlovt
Copy link

pavlovt commented May 28, 2013

I am using List.js with 15 000 and it loads in less than 2 seconds :) (in that case it is better to load the data as json with ajax request)
About your question - the problem is that you are searching in all the data. It's better to give it the data as json and search just by the name of the actor. Then you will get the result you expect.

@javve
Copy link
Owner

javve commented Jun 26, 2013

Hehe, I looked at the code and it took me some time to figure this one out. But here is the problem:

<div style="display:none" class="age">48<span class="category">male</span></div>

The category is inside age which means that you can search for ex category and find everyone :)

This is the way you should do it.

<div style="display:none"><span class="age">48</span><span class="category">male</span></div>

@javve javve closed this as completed Jun 26, 2013
@shotrox
Copy link
Author

shotrox commented Jun 26, 2013

That makes sense ­ although the search for age and male/female works
flawlessŠ

The issue is that when you start typing search terms in the search bar it
sometimes needs 2 or 3 characters to filter out certain actors although none
of the letters are in their namesŠ

It is not a big deal because people don't really figure that out, especially
not when we have hundreds of actors in there

I was just curious why that happens. Maybe other words or code is also
searched and matched against that search term?

From: Jonny Strömberg notifications@github.com
Reply-To: javve/list
<reply+i-14767304-61e66358693f9d6e3ab31a9c11c5f860ebb2bfc8-1617611@reply.git
hub.com>
Date: Wednesday, June 26, 2013 4:49 AM
To: javve/list list@noreply.github.com
Cc: Microsoft Office User info@schottky.com
Subject: Re: [list] Search not 100% accurate? (#126)

Hehe, I looked at the code and it took me some time to figure this one out.
But here is the problem:

48male

The category is inside age which means that you can search for ex category
and find everyone :)

This is the way you should do it.

48male


Reply to this email directly or view it on GitHub
#126 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants