Deprecated toJSON, toCSV, and toExcel methods in frame and series #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #439
This PR deprecates toJSON, toCSV, and toExcel methods. That means we can no longer call them directly on DataFrames and Series, we instead favor using the functions directly. For example:
WHY DID WE DEPRECATE THESE METHODS?
The major reason for deprecating these methods In favor of the functional style is because it is easier and cleaner to separate browser implementation from Nodejs implementation. This ensures we don't do more weird bundling and support Webpack >5 out of the box without extensive configuration.