Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables #30

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Variables #30

merged 4 commits into from
Aug 5, 2020

Conversation

ashpratap007
Copy link
Contributor

Hindi translations for topic "Variables".

@theBstar
Copy link
Member

Thank you for submitting the PR. I will review it by tomorrow.

Copy link
Member

@theBstar theBstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ashpratap007 added a few comments. Overall a good job. Thank you for contributing towards a good cause. Let's make the changes, then we will merge it. Let me know if I can help with anything.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link
Contributor Author

@ashpratap007 ashpratap007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the wonderful review. This being my first open-source contribution, kindly bear with me.

@ashpratap007 ashpratap007 requested a review from theBstar August 3, 2020 08:04
@ashpratap007
Copy link
Contributor Author

/done

@theBstar
Copy link
Member

theBstar commented Aug 5, 2020

Thanks for the wonderful review. This being my first open-source contribution, kindly bear with me.

Hey, It was awesome! Merging this PR. Congrats for your first open-source contribution 🎉🎉. Hoping to see many more from you in the coming days. Thank you.

@theBstar theBstar merged commit 411b351 into javascript-tutorial:master Aug 5, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants