Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Appearance of "Insert Admonition" Command Dialog #190

Closed
juicybox opened this issue Feb 21, 2022 · 4 comments
Closed

Improve Appearance of "Insert Admonition" Command Dialog #190

juicybox opened this issue Feb 21, 2022 · 4 comments

Comments

@juicybox
Copy link

juicybox commented Feb 21, 2022

Please improve the appearance of the Insert admonition command dialog window.

Screenshot_1

Problems

  • dropdown to small (width)
  • icons are overflowed by text
  • new users have too many possible options (might be confusing, what to use..)
    • other (common) workflows
    • doesn't fit into personal scheme
      • would like to use only my types
      • guidelines (personal/company/…)
    • decluttering
      • minimalism
      • focus

Suggestion

Appearance Improvement: Move & Align Icons on the left side (fixed width)

Screenshot_3

Appearance Improvement: full Input width for the dropdown (or even better with auto sizing)

Screenshot_2

Add Configuration Option: Disabled predefined/default options

Add a checkbox in the configuration, to disable

  • all (keep it simple) predefined Admonition types
  • or any user selected (advanced) predefined Admonition types

The user can add custom types, only the required or common used types by themselves.

  • it would be great to disabled the options at least in the select dropdown (the background logic can be the same)
  • or add data-Attributes to the selection Dropdown (for custom CSS, to hide Options from the View)

Screenshot_4

@juicybox juicybox changed the title Improve Appearance of "Insert Admotion" Command Dialog Improve Appearance of "Insert Admonition" Command Dialog Feb 21, 2022
@valentine195
Copy link
Member

dropdown to small (width)
icons are overflowed by text

Does this happen for you on the default theme? I think this might be a theme issue.

Help vault appearance:
Obsidian_Fg2hBMZXry

I did make the suggester full-width, though.

@juicybox
Copy link
Author

@valentine195 Good point, it seems that an issue is related to the theme I'm using "Minimal Theme"

icons are overflowed by text

Some Tests with other common Themes

Default Theme 🆗

Pasted image 20220226030109

Depp Work Theme 🆗

Pasted image 20220226030213

Nord Theme 🆗

Pasted image 20220226030246

Minimal Theme 🐛

Pasted image 20220226030350


  • Obsidian Version : 0.13.26
  • Admotion Version 6.12.1
  • Minimal Theme Version: 5.1

@valentine195
Copy link
Member

Okay, I'm going to consider this closed then.

@juicybox
Copy link
Author

juicybox commented Mar 3, 2022

Okay, I'm going to consider this closed then.

Thanks!

image
Minimal Theme Version: 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants