JUnit5 #52
Open
JUnit5 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 23, 2018 14:22
Todo: add actual descriptions to see what is going on
Increased Unit Test coverage
Test coverage improved.
|
Thank you that looks good. Could you resolve the conflicts so that I can merge? |
added 3 commits
March 26, 2018 10:56
…rn-sandbox into Unit5 # Conflicts: # pom.xml # src/test/java/delight/nashornsandbox/TestSetWriter.java
|
Supposed to be resolved. I would note, that the CPU control isn't a 100%, it sometimes throws runtime exception instead of the expected CPU abuse exception (I would call it "at random"). That needs to be checked on, and it's gonna be a pain to resolve. |
added 3 commits
March 26, 2018 14:23
Moved more test cases into the generic tests. Memory limitation might not work properly, needs a revisit.
|
Sorry I didn't get to this pull request before - I was a bit intimidated by the number of changes :) Would it be possible to remove the generated classes from the pull request? So that I could see easier how the individual tests have changed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests refactored.