Allow sandboxed Invocable::invoke* #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for the pull request! That all looks good. Could you add a quick unit test which uses the feature how you would want to use it? I could create one but I think it would be best if it could be based on the particular requirement you have. |
|
Added some tests. |
|
Perfect, thanks! Merged and released in new version 0.1.12! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to invoke JS functions from Java using javax.script.Invocable, which must also be sandboxed. Therefore, I factored out the code needed for execution of ScriptEngine methods in a new thread and added getSandboxedInvocable() that transparently sandboxes the Invocable::invoke* methods. However, the Invocable::getInterface() methods are only stubs. They could be implemented in a similar fashion using object proxies, if somebody (or I) needs them in the future.
What do you think?