Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix UT performance and npm audit #158

Merged
merged 3 commits into from
Aug 10, 2024
Merged

fix UT performance and npm audit #158

merged 3 commits into from
Aug 10, 2024

Conversation

busterace
Copy link
Contributor

No description provided.

@busterace
Copy link
Contributor Author

  1. fixed UT performance issue, since I lost "();" in JsSanitizer
  2. Remove TestMemoryLimit.test_killed method, since after removing allowNoBraces, test_killed is the same as test_noexpectedbraces
  3. npm build minimize injectJs, js size from 300+KB to 200+KB, Improved execution speed a bit
    @mxro pls review, thanks

@busterace busterace mentioned this pull request Aug 5, 2024
Closed
@busterace
Copy link
Contributor Author

busterace commented Aug 6, 2024 •
edited
Loading

image

after fix, performance is much better 😊

@busterace
Copy link
Contributor Author

@mxro pls review, thanks

@busterace busterace mentioned this pull request Aug 7, 2024
Merged
mxro
mxro approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@mxro mxro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks! Will merge into main branch and run some more tests and prepare for release.

@mxro mxro merged commit ccf0bcb into javadelight:master Aug 10, 2024
1 check passed
@mxro
Copy link
Collaborator

mxro commented Aug 10, 2024

Performance looks outstanding now. Great job!!

0.5.0 released and published to Maven central!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxro mxro mxro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busterace @mxro