Enable retrieval of ACL containing unspported ACEs #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an ACL contained supported (ACCESS_ALLOWED_ACE_TYPE, ACCESS_DENIED_ACE_TYPE) and unsupported types (i.e. ACCESS_ALLOWED_CALLBACK_ACE_TYPE) the constructor threw an IllegalArgumentException. The extraction logic for the ACEs was moved to the accessor function and unsupported ACEs are skipped.
Instead of throwing an Exception or skipping ACEs, alle ACEs in an ACL are returned. If the ACE is an unsupported type, the base structure of all ACEs (ACE_HEADER) is returned. Users of the ACEs contained in the ACL need to check the type and downcast appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #947 this is the agreed upon successor.