Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'showValue' constructor #34

Closed
meiersi opened this issue Dec 31, 2010 · 2 comments
Closed

add 'showValue' constructor #34

meiersi opened this issue Dec 31, 2010 · 2 comments

Comments

@meiersi
Copy link
Collaborator

meiersi commented Dec 31, 2010

Browsing through the help of blaze-html, I found that the conversion of a Showable value to an AttributeValue is missing.
@jaspervdj
Copy link
Owner

Fixed this in cf67ede.

@meiersi
Copy link
Collaborator Author

meiersi commented Dec 31, 2010

Aye that was quick :-)

meiersi added a commit to meiersi/blaze-html that referenced this issue Nov 13, 2011
@meiersi
use &jaspervdj#34; to escape a doublequote
d0f8b64 
- this saves one byte per escaping and thus slightly improves speed and
  compactness.
meiersi added a commit to meiersi/blaze-html that referenced this issue Oct 4, 2012
@meiersi
updated tests
55b8cc6 
- We no longer escape single-quotes (since blaze-markup-0.6.0.0)
- We use &jaspervdj#34; to escape double-quotes
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaspervdj @meiersi