Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASP opens SAV in JASP despite custom editor setting #1189

Closed
keunes opened this issue Mar 2, 2021 · 4 comments · Fixed by jasp-stats/jasp-desktop#4496
Closed

JASP opens SAV in JASP despite custom editor setting #1189

keunes opened this issue Mar 2, 2021 · 4 comments · Fixed by jasp-stats/jasp-desktop#4496
Assignees

Comments

@keunes
Copy link

keunes commented Mar 2, 2021

  • JASP version: 0.14.1
  • OS name and version: Windows 10
  • Bug description: JASP opens SAV in JASP despite custom editor setting
  • Expected behaviour: Open the dataset in LibreOffice, as set in the Data Preferences (C:/Users/first.last/.programmes/LibreOfficePortable/LibreOfficeCalcPortable.exe)

Steps to reproduce:

  1. Make JASP default programme for sav files
  2. Open sav file
  3. Double-click on data array
  4. See error
@boutinb
Copy link
Contributor

boutinb commented Mar 5, 2021

Hi @keunes I thought that LibreOffice could not open a sav file. If it is the case then I could change this behaviour.

@keunes
Copy link
Author

keunes commented Mar 13, 2021

Hi @keunes I thought that LibreOffice could not open a sav file.

I don't know actually, that might be it. Somehow I thought JASP converted the file to CSV or its own format in the background.

Either way, if the set editor can't open it, I'd expect an error rather than current behaviour.

@boutinb
Copy link
Contributor

boutinb commented Mar 15, 2021

Hi @keunes, JASP loads the data from a file (here the sav file), and synchronizes its data each time this file is changed. So it does not make a new file.
As sav file can be edited only by SPSS, that's why when you double-click the data panel to edit the data, JASP assuming that the default application associated with the sav file is SPSS, starts this default application. In your case, it opens JASP again, making it indeed quite confusing.
I'll have a look to this problem. But for the time being, what you can do is to use the 'Export Data' menu: this generates a csv file. If you load this file in JASP, and double-click the data panel, it should then open the LibreOffice application. Each time you modify this file in LibreOffice, JASP should synchronize its data with your change (and rerun the analyses in case).

@keunes
Copy link
Author

keunes commented Mar 19, 2021

JASP loads the data from a file (here the sav file), and synchronizes its data each time this file is changed. So it does not make a new file
for the time being, what you can do is to use the 'Export Data' menu: this generates a csv file

Hah, ok. I understand. I also have a CSV version of my dataset, so I can use that. But thanks for the tip :)

It was more about usability; just to get the vicious circle fixed for others. 'cause it's still odd that the 'custom editor' setting is ignored. I would expect LO to try and open it, then say "sorry, can't handle it"

boutinb added a commit to boutinb/jasp-desktop that referenced this issue Mar 24, 2021
Fixes jasp-stats/jasp-issues#1189

When the file is a sav file, JASP used to bypass the user settings, and
start always the default editor associated with this kind of file, with
the presumption that SPSS is this default application for sav file.
But this might be confusing: some users have set JASP as default
application, starting JASP a second time when double-clicking the data
panel
JorisGoosen pushed a commit to jasp-stats/jasp-desktop that referenced this issue Mar 30, 2021
…4496)

* Use user setting also when starting spreadsheet editor for sav file.

Fixes jasp-stats/jasp-issues#1189

When the file is a sav file, JASP used to bypass the user settings, and
start always the default editor associated with this kind of file, with
the presumption that SPSS is this default application for sav file.
But this might be confusing: some users have set JASP as default
application, starting JASP a second time when double-clicking the data
panel

* Display whole name of the file in the error message when no default application exists for the kind of file to be opened

Fixes jasp-stats/jasp-issues#1203

* Ask user if he wants to generate a css file when the default application for a the file fails to start.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants