Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an "upgrade" that resets the analysis to defaults #5693

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

JorisGoosen
Copy link
Contributor

add an "upgrade" that resets the analysis to defaults

Implements https://github.com/jasp-stats/INTERNAL-jasp/issues/2660

Show an error in Analysis after loading.
There is a testcase in testModule

image

add an "upgrade" that resets the analysis to defaults

Implements jasp-stats/INTERNAL-jasp#2660

Show an error in Analysis after loading
@JorisGoosen
Copy link
Contributor Author

Its called "ChangeIncompatible" and you can basically only set a 'msg' which is then shown as an error.

jasp-stats/jaspTestModule@78b8369

@JorisGoosen JorisGoosen requested a review from boutinb October 10, 2024 13:45
Copy link
Contributor

@boutinb boutinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make it translatable

Co-authored-by: bruno boutin <b.boutin@uva.nl>
@JorisGoosen JorisGoosen merged commit 79fe683 into jasp-stats:development Oct 10, 2024
1 check passed
RensDofferhoff pushed a commit to RensDofferhoff/jasp-desktop that referenced this pull request Oct 15, 2024
* upgrade seems ok, now just show the msg somewhere the user can see it

add an "upgrade" that resets the analysis to defaults

Implements jasp-stats/INTERNAL-jasp#2660

Show an error in Analysis after loading

* translatable please
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants