bugfix: replace newlines with _ in CSV cell values #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But what is the problem with newlines in values? While I agree users shouldnt really do that I think replacing them by '_' is a bit brusque. |
|
The vaule with newlines will overflow from cells after imported CSV, perhaps adjusting the cell height is an option, but I feel that there is a risk of line breaks appearing in the data anyway, which might cause confusion on the unpredictable R code side. I don't know, but overflowing the data view is an obvious problem right now. |
|
I mean: After: Even we dont allow user input 'newline' inside cells right:-) |
|
Well, that is why I replaced the newlines with spaces :p |
JorisGoosen
approved these changes
Sep 16, 2024
JorisGoosen
pushed a commit
that referenced
this pull request
Sep 30, 2024
* bugfix: replace newlines with _ in CSV cell values * replace newlines with spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other data file will not have this problems because newlines in values were not allowed.
I think
_is better than a space, because space invisible sometimes, so that we should also change: https://github.com/jasp-stats/jaspColumnEncoder/blob/3425813804558ea0246351e3b361c19fffcf73f4/stringutils.h#L188 ?