-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement R code highlight #5102
Conversation
awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!!!
Just one remark.
Could we also use this to highlight the rcode in textareas in the gui? Ive done some reading in the https://doc.qt.io/qt-6/qsyntaxhighlighter.html and some related pages. But if we have a regex that can highlight R we could use that. And looking in the PR I guess the highlighter itself already has some definition inside. Ill have a look at their docs Edit: https://github.com/highlightjs/highlight.js/blob/main/src/languages/r.js seems quite useful for implementing this later. Having R code look awesome in the results-notes will already be very nice. |
Is there a way to import js directly in QML? However that seems to require using qmake build system? if so sounds terrible🤪
I recommend here https://prismjs.com/download.html#themes=prism&languages=r |
Well it is possible to include
https://github.com/PrismJS/prism/blob/master/components/prism-r.js |
Now in help docs:
So I think it ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ^^ |
@boutinb you think you can also review this? |
Close: https://github.com/jasp-stats/INTERNAL-jasp/issues/2328
Now looks like:
TODO: