Copy LaTeX of table does not copy html code #5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kucharssim
changed the title
JorisGoosen
requested review from
RensDofferhoff
and removed request for
JorisGoosen
6 tasks
JorisGoosen
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2201
Not sure if this is the ideal point where to fix this, but this gets rid of the unwanted html tags in the copied LaTeX code and does not break any other copying functionality that I know of and managed to test.
The other issues in https://github.com/jasp-stats/INTERNAL-jasp/issues/2201 (i.e., copy table to word, copy citations) seem to be already fixed.
Just out of curiosity, the bug seems to have been introduced in 997bc6a marked to solve https://github.com/jasp-stats/INTERNAL-jasp/issues/296. However, either I am doing something wrong or the issue in https://github.com/jasp-stats/INTERNAL-jasp/issues/296 still persists. Am I right we need to reopen the issue?