Skip to content

Commit

Permalink
Namespace the resources, and bump the getting started version to 1.0.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jason Feinstein committed May 10, 2016
1 parent 9468f1c commit 7f56527
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ allprojects {
In your application's `build.gradle` file, add a dependency for Android DebugPort:

```groovy
debugCompile 'com.github.jasonwyatt:Android-DebugPort:0.5'
testCompile 'com.github.jasonwyatt:Android-DebugPort:0.5'
releaseCompile 'com.github.jasonwyatt:Android-DebugPort-NOOP:0.5'
debugCompile 'com.github.jasonwyatt:Android-DebugPort:1.0'
testCompile 'com.github.jasonwyatt:Android-DebugPort:1.0'
releaseCompile 'com.github.jasonwyatt:Android-DebugPort-NOOP:1.0'
```

**Note:** The final line above will use a [no-op version of the DebugPort library](https://github.com/jasonwyatt/Android-DebugPort-NOOP) in production builds. This makes it impossible for people to run the DebugPort server on a production build.
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<application
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:label="@string/debugport_app_name"
android:supportsRtl="true"
android:theme="@style/AppTheme"
android:name=".App">
Expand Down
2 changes: 1 addition & 1 deletion library/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<application
android:allowBackup="true"
android:label="@string/app_name"
android:label="@string/debugport_app_name"
android:supportsRtl="true">

<service android:name=".DebugPortService" android:exported="false"/>
Expand Down
6 changes: 3 additions & 3 deletions library/src/main/java/jwf/debugport/DebugPortService.java
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ protected void onPostExecute(Params params) {
Context context = DebugPortService.this;
Notification.Builder builder = new Notification.Builder(DebugPortService.this);
builder.setSmallIcon(R.drawable.debugport_ic_notification);
builder.setContentTitle(getString(R.string.notification_title));
builder.setContentTitle(getString(R.string.debugport_notification_title));
String ip = Utils.getIpAddress(context);
String message = getString(R.string.notification_subtitle, ip, params.getDebugPort(), params.getSQLitePort());
String summary = getString(R.string.notification_summary, ip, params.getDebugPort(), params.getSQLitePort());
String message = getString(R.string.debugport_notification_subtitle, ip, params.getDebugPort(), params.getSQLitePort());
String summary = getString(R.string.debugport_notification_summary, ip, params.getDebugPort(), params.getSQLitePort());
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
builder.setStyle(new Notification.BigTextStyle().bigText(message).setSummaryText(summary));
builder.setContentText(message);
Expand Down
8 changes: 4 additions & 4 deletions library/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<resources>
<string name="app_name">Android DebugPort</string>
<string name="notification_title">Android DebugPort Running</string>
<string name="notification_subtitle">Debug Running at %1$s:%2$d\nSQLite Running at %1$s:%3$d</string>
<string name="notification_summary">Debug: %1$s:%2$d, SQLite: %1$s:%3$d</string>
<string name="debugport_app_name">Android DebugPort</string>
<string name="debugport_notification_title">Android DebugPort Running</string>
<string name="debugport_notification_subtitle">Debug Running at %1$s:%2$d\nSQLite Running at %1$s:%3$d</string>
<string name="debugport_notification_summary">Debug: %1$s:%2$d, SQLite: %1$s:%3$d</string>
</resources>

0 comments on commit 7f56527

Please sign in to comment.