Heartbeat flexibility to support ActiveMQ #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properly with ActiveMQ
put guards around the send and receive heartbeat code based on whether the interval was 0 or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to make stomp.py work with ActiveMQ when the heartbeat was activate because stomp.py would fire a heartbeat timeout and disconnect. Some of the issue seemed to be that by default ActiveMQ backs off the first heartbeat by the same as the heartbeat timeout, effectively skipping the first beat. Also, the 2 second grace on the receive heartbeat didn't always seem sufficient. In ActiveMQ they suggest a 50% grace, which I've implemented here.
Also, I removed diff_heartbeat as it was identical logic to diff_receive.
Finally, I put some guard code around the heartbeat sending and receiving because if I just was to enable client heartbeats, and have the server heartbeat at 0 then the code as it stood would timeout immediately.