Support mixed string and bytes as input #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By encoding each frame part before packing (as we already do for Python 3) we avoid raising a UnicodeDecodeError for perfectly legitimate bunch of strings. Without this part by part encoding, both py2 and py3 version of pack would fail, so I added the test to both.
|
That was a quick merge, thanks! 🐎 |
|
Thanks for the contribution, btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some smart programmers may cautiously encode a unicode string to "bytestring" when setting their message body/headers, however this would currently fail on python 2 if they left in any unicode; even an empty unicode literal (
u'').By encoding each frame part before packing (as we already do for Python 3) we avoid raising a
UnicodeDecodeErrorfor perfectly encoded bunch of strings.Without this "part-by-part encoding", both py2 and py3 version of pack would fail
test_pack_mixed_string_and_bytes, so I added the test to both, and with the fix both now pass.