fix: correct WSTransport.receive output #422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I was trying this out and eventually found this bug - I get an
AttributeError: 'bytes' object has no attribute 'encode'
. I think this is becauseself.socket.recv()
returns either bytes or str, so this PR just handles the case where a string is returned and encodes to bytes - it seems like that's how you wanted this function to behave.Let me know if I've missed anything - thanks!