mock dns responses to make running tests easier and more efficient #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By monkeypatching
socket.getaddrinfo()
in a couple of places, the requirement to addentries to the hosts file (which usually requires root access) is removed. It also
avoid long timeouts in dual-stack IPv4/IPv6 environments where the tests try to connect
to the IPv6 address for localhost first, but the test service is only listening on the
IPv4 address.
Also update
test_alternate_hosts()
to wait for a successful connection, and fix alogic error in
StubStompServer
whereget_next_frame()
was returning an empty string but thecaller was testing for
None
.