Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use CONNECT command for 1.1, 1.2 #348

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

JDeeth
Copy link

@JDeeth JDeeth commented Mar 11, 2021

The STOMP spec indicates that 1.1 and 1.2 clients should be able to
connect with the CONNECT command if needed for backward
compatibility. This adds a keyword argument to the connect methods
of both protocols to let the user select STOMP or CONNECT. STOMP
remains the default.

Fixes #347

The STOMP spec indicates that 1.1 and 1.2 clients should be able to
connect with the CONNECT command if needed for backward
compatibility. This adds a keyword argument to the `connect` methods
of both protocols to let the user select STOMP or CONNECT. STOMP
remains the default.
@jasonrbriggs jasonrbriggs merged commit 787d2df into jasonrbriggs:dev Apr 9, 2021
@jasonrbriggs
Copy link
Owner

Thanks!

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 14, 2022
https://build.opensuse.org/request/show/954212
by user sebix + dimstar_suse
- Relieve python dependencies (replace ^ with >=).
- remove need for two source tarballs, use only the github one with pyproject macros
- update to version 8.0.0:
 * Add support for backwards compatible CONNECT in 1.1 and 1.2 protocols (jasonrbriggs/stomp.py#348)
 * Flip DEFAULT_SSL_VERSION to use ssl.PROTOCOL_TLS rather than ssl.PROTOCOL_TLSv1
 * Check SSL certificate for expiry if PyOpenSSL is installed
 * Remove deprecated constructor params (use_ssl, and other ssl params)
 * Minor cleanup (remove debian packaging config, since it didn't work any more)
 * Add log_to_stdout method to force command line logging to stdout (useful for testing)
 * Various updates for docker testing
 * Add mac keepalive functionality
 * Minor update to daemon attribute (https://github.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.1 clients should continue to use the CONNECT command?
2 participants