Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation includes calls to conn.start() but start() is marked as deprecated #257

Closed
huntermassey opened this issue Oct 25, 2019 · 2 comments
Closed

Documentation includes calls to conn.start() but start() is marked as deprecated #257

huntermassey opened this issue Oct 25, 2019 · 2 comments

Comments

@huntermassey
Copy link

Per title, the README and documentation includes calls to start() after creating a connection, but it appears that start() is no longer required and is marked as deprecated.
@AaronDMarasco
Copy link
Contributor

If you want SSL or TLS handshaking, I'm pretty sure start() is required at the transport level - see #259. Without it, I couldn't get my stuff to connect.

@jasonrbriggs
Copy link
Owner

@AaronDMarasco start/stop in the transport still exists, but on the connection it isn't required.

@huntermassey to be fixed in version 4.2.0 (releasing in the new year)

@Caligatio Caligatio mentioned this issue Jan 3, 2020
Closed
bmwiedemann added a commit to bmwiedemann/openSUSE that referenced this issue Jan 6, 2020
@bmwiedemann
Update python-stomp.py to rev 5 via SR 761142
2974f4b 
https://build.opensuse.org/request/show/761142
by user dimstar_suse
- dropped Python 2 support, not supported by the package
- update to version 5.0.0:
 * Fix for credentials exposure (jasonrbriggs/stomp.py#244)
 * Check for ``STOMP_SKIP_HOSTNAME_SCAN`` environment variable before extending ``LOCALHOST_NAMES``
 * Remove python2 backwards compatibility
 * Update dockerfile for better local testing
 * Fix docker and travis setup, so there are consistent builds both locally and via CI
 * Drop deprecated start/stop methods from connection (issue jasonrbriggs/stomp.py#257)
 * Fix for missing return in get_ssl (jasonrbriggs/stomp.py#258)
 * Clear heartbeat event after heartbeat loop ends (jasonrbriggs/stomp.py#260)
 * Update listener to move receive/message_received/
ghost pushed a commit to certtools/intelmq that referenced this issue Mar 9, 2020
BUG: stomp collector compatibility fixes
db35d2e 
fixing compatiblity for stomp.py >= 4.1.20 up to 6.0.0

references:

removed unused wait_on_receipt parameter
jasonrbriggs/stomp.py#237

Drop deprecated start/stop methods from connection
jasonrbriggs/stomp.py#257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasonrbriggs @huntermassey @AaronDMarasco