Adding new alerts endpoint with dictionary/object response format #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DerickJohnson
commented
Jan 16, 2023
•
DerickJohnson
commented
- Added new /alerts/pw endpoint to respond with alerts in dictionary/object format
- Updated alerts lists with ones from my system
- Related to Enhancement Request: Alerts from Vitals Powerwall-Dashboard#158
|
@jasonacox I left out changes to the server-r.py file, but let me know if you want those committed as well (I have them locally). I wasn't sure if you wanted that included. |
jasonacox
reviewed
Jan 16, 2023
| @@ -588,22 +588,34 @@ Example Output: [here](https://github.com/jasonacox/pypowerwall/blob/main/docs/v | |||
|
|
|||
| * Alerts | |||
| * BackfeedLimited - Unknown | |||
| * BatteryBreakerOpen | |||
There was a problem hiding this comment.
Excellent! Thanks for the additional alerts.
|
Thanks @DerickJohnson ! This is a logical addition to help with alert history tracking. |
|
Your change is live: jasonacox/pypowerwall:latest - thank you! I'll update the Powerwall-Dashboard release notes (which pulls latest by default). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.