-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the proxy. #143
Draft
Nexarian
wants to merge
4
commits into
jasonacox:main
Choose a base branch
from
Nexarian:re-work-proxy-next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,13 @@ | ||
FROM python:3.10-alpine | ||
FROM python:3.13-alpine | ||
RUN apk add gcc python3-dev musl-dev linux-headers | ||
WORKDIR /app | ||
COPY requirements.txt /app/requirements.txt | ||
COPY ./proxy/requirements.txt /app/requirements.txt | ||
RUN pip3 install --upgrade pip | ||
RUN pip3 install -r requirements.txt | ||
COPY . . | ||
COPY pypowerwall /app/pypowerwall/pypowerwall/ | ||
COPY setup.py requirements.txt README.md /app/pypowerwall/ | ||
RUN pip3 install /app/pypowerwall | ||
COPY ./proxy . | ||
CMD ["python3", "server.py"] | ||
EXPOSE 8675 | ||
EXPOSE 8675 | ||
EXPOSE 8685 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,11 @@ | ||
pypowerwall==0.12.6 | ||
bs4==0.0.2 | ||
beautifulsoup4 | ||
bs4 | ||
protobuf | ||
psutil | ||
pypowerwall | ||
pyroute2 | ||
requests | ||
setuptools | ||
teslapy | ||
urllib3 | ||
wheel |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume most would build the container from the directory that contains the Dockerfile (proxy), which is where my automation goes to build and push the proxy container. This would break that. Did you have another idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this because I needed to test changes to the proxy AND pypowerwall itself and I didn't know of another good way to build them together, did I miss the memo on how to do that?
Anyway, I think what I should do is move this configuration to a different Dockerfile and leave this one alone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. My dev and beta build script copies the library before running the build (
cp -r ../pypowerwall .
)