Remove option to set email sender name in pwstatus #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the option to set the e-mail sender name in the pwstatus script and config for better compatibility.
I noticed an issue when setting up a new test system, where the "-F" option of "mail" was no longer accepted to set the name of the e-mail sender (possibly due to a new version of postfix or mailx?).
I guess setting the FROM name of the sender probably should be left up to the user and their MUA/MTA/system setup instead.
The "mail" command used in the script is now generic and in the form of
mail -s "subject" [recipient-email-address]only, which should be more generally accepted.