Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support powerwall.extend.yml & backup.sh.sample #186

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

BJReplay
Copy link
Contributor

@BJReplay BJReplay commented Feb 20, 2023

Apologies for six different commits. The first four are two commits and two more undoing them - the changes to update.sh.

The next two are the meat on the bones. The changes to compose-dash.sh look for the existence of powerwall.extend.yml, and if it exists, initialise a variable with -f powerwall.extend.yml to be included in the docker compose or docker-compose commands (whatever they are) so that the docker compose command works on both powerwall.yml and powerwall.extend.yml.

I used this to shut down my customised powerwall.yml, bring up the standard one (with Weather411 added back in), shut it down, bring up one with Ecowitt added back in (by creating powerwall.extend.yml).

The other change here is to the snippet in the instructions for the Ecowitt weather service to add in the version and services tags that allow this yaml to be merged.

Associated change to the readme noting this.

Final change here is a rename of backup.sh to backup.sh.sample, and associated change to the readme: I got bitten by the upgrade today when my customised backup.sh got overwritten by the upgrade.sh and a second commit with improved instructions.

Supports a customised powerwall through the upgrade by preserving it before the upgrade by copying it to a .restore copy, and restoring it after the git pull before restarting the containers.
Supports a customised powerwall.yml Docker Compose file through the upgrade by preserving it before the upgrade by copying it to a .preserve copy, and restoring it after the git pull before restarting the containers.
Support Extending powerwall.yml by modifying compose-dash.sh to look for powerwall.extend.yml and including it in docker compose commands.

Change backup.sh to backup.sh.sample.

Modify instructions to indicate that backup.sh.sample should be copied to backup.sh
@jasonacox
Copy link
Owner

Excellent! Thanks @BJReplay ! Good enhancement that creates a clean and supported path to add custom docker additions or tools. 🙏 And, brilliant call on backup.sh.

Thanks @mcbirse for spotting the docker compose extends path.

@jasonacox jasonacox merged commit ed8d4e9 into jasonacox:main Feb 20, 2023
@jasonacox
Copy link
Owner

Released as v2.8.4 - Custom Docker Compose Support

Thanks again @BJReplay !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants