Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less algebra #702

Closed
wants to merge 1 commit into from
Closed

Less algebra #702

wants to merge 1 commit into from

Conversation

eponier
Copy link
Contributor

@eponier eponier commented Jan 25, 2024

This is an experiment to check on how much we depend on mathcomp.algebra.

It seems that we really depend only on ssralg and ssrnum.

We also depend on:

  • ssrint: it seems that we only use the coercion nat >-> Z, I introduced Z.of_nat where appropriate, but we could also declare Z.of_nat as a coercion.
  • zmodp: to manipulate ordinals used by nth (one occurrence only)

Note that we still indirectly rely on all algebra because of coqword.

Context: mathcomp 2 slows the compilation down; maybe if we use less of mathcomp, the impact is smaller.

@eponier
Copy link
Contributor Author

eponier commented Jan 25, 2024

We could also check the dependencies on a per-file basis, but this is probably not worth the work.

Only ssralg and ssrnum are required.
@bgregoir
Copy link
Contributor

bgregoir commented Feb 1, 2024

This looks good, can you also do a PR for coqword ?
Maybe this will allow to do some benchmarks.

@eponier
Copy link
Contributor Author

eponier commented Mar 21, 2024

Subsumed by #765.

@eponier eponier closed this Mar 21, 2024
@eponier eponier deleted the less-algebra branch March 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants