-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wint2 #1071
Open
bgregoir
wants to merge
19
commits into
main
Choose a base branch
from
wint2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e25d51
to
782d51c
Compare
vbgl
reviewed
Mar 4, 2025
Comment on lines
+32
to
+36
| WIword_of_int of wsize (* int → word *) | ||
| WIint_of_word of wsize (* word/uint/sint → int, signed or unsigned interpretation *) | ||
| WIword_of_wint of wsize (* uint/sint -> word *) | ||
| WIwint_of_word of wsize (* word -> uint/sint *) | ||
| WIword_ext of wsize & wsize (* Sign-extension: output-size, input-size *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| WIword_of_int of wsize (* int → word *) | |
| WIint_of_word of wsize (* word/uint/sint → int, signed or unsigned interpretation *) | |
| WIword_of_wint of wsize (* uint/sint -> word *) | |
| WIwint_of_word of wsize (* word -> uint/sint *) | |
| WIword_ext of wsize & wsize (* Sign-extension: output-size, input-size *) | |
| WIwint_of_int of wsize (* int → word *) | |
| WIint_of_wint of wsize (* word/uint/sint → int, signed or unsigned interpretation *) | |
| WIword_of_wint of wsize (* uint/sint -> word *) | |
| WIwint_of_word of wsize (* word -> uint/sint *) | |
| WIwint_ext of wsize & wsize (* Sign-extension: output-size, input-size *) |
(note to self)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce new types in jasmin source: siXX and uiXX.
For the compiler they are equal to wXX.
It also introduce the operator word_to_sint and word_to_uint
(int) w : is word_to_uint (for compatibility)
(uint) w : is word_to_uint
(sint) w : is word_to_sint ( NEW)
(XXsi) w : cast from wXX to siXX
(XXsi) si : cast from siYY to siXX
(XXsi) i : cast from int to sint
Same with XXui
(int) si | (sint) si : cast from siXX to int
(int) ui | (uint) si : cast from uiXX to int
New notation for uXX : wXX is not accepted and used for printing
Compilation starts by replacing all operations on siXX uiXX by corresponding wXX operations.
Extraction starts by replacing all operations on siXX uiXX by corresponding int operations.