Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contains fromIndex #2072

Merged
merged 1 commit into from
Feb 20, 2015
Merged

Contains fromIndex #2072

merged 1 commit into from
Feb 20, 2015

Conversation

jridgewell
Copy link
Collaborator

Aligns with ES6’s contains.

Re: #1962
Re: #2061, 4f771e0

michaelficarra added a commit that referenced this pull request Feb 20, 2015
@michaelficarra
Merge pull request #2072 from jridgewell/contains-fromIndex
fad78fd 
Contains fromIndex
@michaelficarra michaelficarra merged commit fad78fd into jashkenas:master Feb 20, 2015
@jashkenas
Copy link
Owner

fromIndex is a really strange thing to have in a contains. Is there a good use-case for it — or is it only because you get it for free with indexOf? If there's no good reason, why clutter the API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jridgewell @jashkenas @michaelficarra @gyeates