Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test shimmed bind + normal bind #1711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jun 28, 2014

Just some coverage of the shimmed bind

@michaelficarra
Copy link
Collaborator

Can you reset it to its original value afterward? Also, I'm not sure how I feel about a test being run conditionally based on the environment.

@megawac
Copy link
Collaborator Author

megawac commented Jun 28, 2014

It's part of the test suite, do you really think its necessary to reset it afterwards?

@michaelficarra
Copy link
Collaborator

I know it's not necessary to reset it, but I think it's best to try to make the tests as independent as possible.

package.json Outdated
@@ -18,7 +18,7 @@
"version": "1.6.0",
"devDependencies": {
"docco": "0.6.x",
"phantomjs": "1.9.7-1",
"phantomjs": "1.9.7-11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did phantomjs finally get Function#bind?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like it I probably should revert that change

@michaelficarra
Copy link
Collaborator

@megawac rebase?

@jgonggrijp
Copy link
Collaborator

Only meaningful if #2845 gets merged.

@jgonggrijp jgonggrijp added the test label May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants