handle triple-quoted JSX attribute values

jashkenas · Apr 22, 2021 · 74c75d2 · 74c75d2
1 parent 07f644c
commit 74c75d2
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 6 deletions.
diff --git a/lib/coffeescript/nodes.js b/lib/coffeescript/nodes.js
diff --git a/src/nodes.coffee b/src/nodes.coffee
@@ -1708,7 +1708,7 @@ exports.JSXAttribute = class JSXAttribute extends Base
     @value =
       if value?
         value = value.base
-        if value instanceof StringLiteral
+        if value instanceof StringLiteral and not value.shouldGenerateTemplateLiteral()
           value
         else
           new JSXExpressionContainer value
@@ -5146,13 +5146,13 @@ exports.Parens = class Parens extends Base
 #### StringWithInterpolations
 
 exports.StringWithInterpolations = class StringWithInterpolations extends Base
-  constructor: (@body, {@quote, @startQuote} = {}) ->
+  constructor: (@body, {@quote, @startQuote, @jsxAttribute} = {}) ->
     super()
 
   @fromStringLiteral: (stringLiteral) ->
     updatedString = stringLiteral.withoutQuotesInLocationData()
     updatedStringValue = new Value(updatedString).withLocationDataFrom updatedString
-    new StringWithInterpolations Block.wrap([updatedStringValue]), quote: stringLiteral.quote
+    new StringWithInterpolations Block.wrap([updatedStringValue]), quote: stringLiteral.quote, jsxAttribute: stringLiteral.jsxAttribute
     .withLocationDataFrom stringLiteral
 
   children: ['body']

diff --git a/test/jsx.coffee b/test/jsx.coffee
@@ -946,3 +946,24 @@ test '“Adjacent” tags on separate lines should still compile', ->
       return <b />;
     });
   '''
+
+test '#5352: triple-quoted non-interpolated attribute values', ->
+  eqJS '''
+    <div a="""
+      b
+      c
+    """ />
+  ''', '''
+    <div a={`b
+    c`} />;
+  '''
+
+  eqJS """
+    <div a='''
+      b
+      c
+    ''' />
+  """, '''
+    <div a={`b
+    c`} />;
+  '''