Skip to content
This repository was archived by the owner on Mar 5, 2022. It is now read-only.

Feature request: Adapt number of search results to terminal height #218

Closed
forthrin opened this issue Feb 4, 2018 · 1 comment
Closed

Comments

@forthrin
Copy link

forthrin commented Feb 4, 2018

By default, googler should show a number of search results that fits within the current terminal height.

Right now, 10 is the default, which means you always have to scroll back to see the first hits if you have a window of less than 60 lines (which is quite tall!) You always have to scroll back = Not user friendly.

To fit more search results into the terminal, one could also look into setting a cutoff length for site descriptions, which can run into hundreds of characters for some sites, while others are quite short.

@jarun jarun added the duplicate label Feb 4, 2018
@jarun
Copy link
Owner

jarun commented Feb 4, 2018

See #207.

I'll see how easy it is to use URL folding like we do in ddgr (if I ever get the time) but that would be the best you get.

If you don't like the idea a PR for review is welcome.

@jarun jarun closed this as completed Feb 4, 2018
jarun added a commit that referenced this issue Feb 5, 2018
We have explained in #207 our reservations regarding automatically adjusting the
number of search results according to the terminal size in googler. However, we
have the option to show the domain name only instead of the complete URL. This
is a visual change and many modern browsers do it. We cannot make it default at
this stage of the project. So I chose to use an environment variable. There's a
new omniprompt switch (`u`) to toggle it at runtime.
@jarun jarun mentioned this issue Oct 10, 2018
This was referenced Apr 21, 2019
@lock lock bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants