-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jarun#702] implemented fetch-status & export-on operations #721
Merged
+1,160
−407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
LeXofLeviafan
commented
Mar 7, 2024
c5bdbd0
to
3e52a25
Compare
…Whoa. These typings are really hard to appease on multiple Python versions. |
jarun
requested changes
Mar 8, 2024
3e52a25
to
cc2bdee
Compare
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #702 and #708:
fetch_data()
function returning aFetchResult
namedtuple including additional information (+deprecatingnetwork_handler()
)--url-redirect
option for add/update action (url_redirect
parameter in API) to update the URL by following permanent redirects--tag-redirect
option for add/update action (tag_redirect
parameter in API) to procure an extra tag based on HTTP code (when it's a permanent redirect); optionally customizing the tag--tag-error
option for add/update action (tag_error
parameter in API) to procure an extra tag based on HTTP code (when it's an error response); optionally customizing the tag--del-error
option for add/update action (del_error
parameter in API) to delete/prevent adding the URL upon receiving an error response; optionally specifying which errors are matched (a network error will always match when adding, but not when updating – to prevent deleting existing bookmarks due to a network failure)--export-on
option for add/update action (export_on
parameter in API) to adjust the output of an--export
(filtering export by matched HTTP responses and including replaced URLs/deleted bookmarks in the output); this matches the HTTP codes of other such operations by default, which optionally can be overriddenalso:
fetch_data()
responsesupdate_rec()
,append_tag_at_index()
,delete_tag_at_index()
,refreshdb()
,print_rec()