Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bukuserver] Readonly mode #631

Merged
merged 1 commit into from
Dec 3, 2022
Merged

[bukuserver] Readonly mode #631

merged 1 commit into from
Dec 3, 2022

Conversation

LeXofLeviafan
Copy link
Collaborator

fixes #549:

  • adding a BUKUSERVER_READONLY boolean environment variable
  • implementing a generic editing disabler for a model based on the value of said variable
  • applying said disabler to bookmark & tag models

also:

  • improving description of DISABLE_FAVICON (for clarity)
  • adding a space after the bookmark favicon for visual improvement

rachmadaniHaryono
rachmadaniHaryono approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@rachmadaniHaryono rachmadaniHaryono left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm it work

TagModelView actually dont have edit/create/delete operation but have it will make it easier in the future

to test it run

BUKUSERVER_READONLY=true python -m bukuserver run

i'm also ok with favicon edit

for completion, favicon issue is discussed here #621 , but not fixed by this pr

@jarun jarun merged commit 3e407bf into jarun:master Dec 3, 2022
@jarun
Copy link
Owner

jarun commented Dec 3, 2022

Thank you!

@LeXofLeviafan
Copy link
Collaborator Author

TagModelView actually dont have edit/create/delete operation

image

@rachmadaniHaryono rachmadaniHaryono mentioned this pull request Dec 3, 2022
Closed
@rachmadaniHaryono
Copy link
Collaborator

@LeXofLeviafan yeah you are correct, i miss that and only notice can_create = False on TagModelView and skip (delete/update)_model method

@LeXofLeviafan LeXofLeviafan deleted the readonly-mode branch December 5, 2022 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachmadaniHaryono rachmadaniHaryono rachmadaniHaryono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] [bukuserver] Read Only Mode
3 participants
@LeXofLeviafan @jarun @rachmadaniHaryono