Add --preserve option

[humCopper]

Adds preserve option like in #327.

[rachmadaniHaryono]

@jarun can we add annotation for update_rec function?

also @humCopper can you add test for this?

[jarun]

can we add annotation

Sure!

[humCopper]

I don't know how to do the tests. Are there any tutorials I can follow?

[jarun]

I don't know how to do the tests. Are there any tutorials I can follow?

@rachmadaniHaryono please guide. Can this be a separate PR?

[rachmadaniHaryono]

Can this be a separate PR?

yes

for guide, kinda basic

• first make sure you have virtual environment activated
  • if not follow the instruction from here https://virtualenv.pypa.io/en/latest/
• install pytest
• run pytest
• create test function
• run pytest again

[jarun]

OK, then! @humCopper please raise a new PR for the tests. I have merged this one. Thank you!

[rachmadaniHaryono]

i remove myself and review on later pr

[jarun]

OK. Thanks!

[jarun]

@humCopper we need to revert this and you have to raise a fresh PR for the correct use-case.

The --preserve option is for the following cases:

buku -u
buku -u db_index

basically the cases where refreshdb() is called. I had forgotten the context and I assumed that you have understood the use-case clearly as you raised the PR directly.

For update_rec() with options, users can specify which fields to update already so `--preserve doesn't make sense.

Please make refreshdb() handle --preserve.

[jarun]

@humCopper are you planning to modify the changes made in this PR to work for refreshdb()?

[humCopper]

Not right now.