Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iterator on etcd adapter #857

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

chrisllontop
Copy link
Contributor

@chrisllontop chrisllontop commented Jul 1, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (294661a) 100.00% compared to head (8bd9192) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #857   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2573      2584   +11     
  Branches       335       338    +3     
=========================================
+ Hits          2573      2584   +11     
Impacted Files Coverage Δ
packages/etcd/src/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray jaredwray merged commit 3d1c6ba into jaredwray:main Jul 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants