Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maximum call stack size exceeded #827

Merged
merged 2 commits into from
May 28, 2023
Merged

Conversation

AuspeXeu
Copy link
Contributor

Unfortunately, if the redis database has many entries, the current approach using recursion can run into a maximum call stack size exceeded exception.

image

@lzfxxx
Copy link

lzfxxx commented May 26, 2023

@jaredwray I've also encountered the same issue that's been addressed by this Pull Request #827 from @AuspeXeu. The problem with maximum call stack size exceeded exception due to recursion when the redis database has many entries is affecting my project as well. I kindly request that this Pull Request be considered for merging at the earliest possible convenience to resolve this common issue. I appreciate your work on this project and thank you in advance for your attention to this matter.

@jaredwray
Copy link
Owner

@AuspeXeu and @lzfxxx - thanks for the pull request. Can you get this updated as we just converted Redis to typescript. Can you do it based on that and make sure the tests run successfully so I can validate?

@AuspeXeu
Copy link
Contributor Author

@jaredwray the tests fail due to a linting rule. Which does not seem to make sense for this particular case. Maybe we can deactivate it?

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2919dff) 100.00% compared to head (db22e5c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #827   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2465      2461    -4     
  Branches       245       245           
=========================================
- Hits          2465      2461    -4     
Impacted Files Coverage Δ
packages/redis/src/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray jaredwray merged commit 165c841 into jaredwray:main May 28, 2023
@jaredwray
Copy link
Owner

@AuspeXeu and @lzfxxx this should be released next weekend with other updates. Thanks so much for the pull request!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants